From 8993de76f0597dc4345551c8cab403352418e84b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Florian=20M=C3=BCllner?= Date: Fri, 7 Aug 2020 21:35:35 +0200 Subject: [PATCH] ci: Remove pot file test A recent Docker image update broke the test, as xgettext now prints the following warning: warning: a fallback ITS rule file '/usr/share/gettext-0.21/its/metainfo.its' is used; it may not be in sync with the upstream That is completely unrelated to what the test is meant to catch and could be fixed by adding appstream to the image, but considering that - the test didn't actually catch the last template string regression - we no longer allow template strings in files that include translatable strings (and enforce that with a CI job) - as of gettext 0.20.2, the template handling really really is fixed (we'll see) let's remove the test rather than piling up more stuff in the container image. https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/1399 --- .gitlab-ci.yml | 18 ------------------ 1 file changed, 18 deletions(-) diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml index ee34776f3..adad8f958 100644 --- a/.gitlab-ci.yml +++ b/.gitlab-ci.yml @@ -9,7 +9,6 @@ stages: variables: BUNDLE: "extensions-git.flatpak" JS_LOG: "js-report.txt" - POT_LOG: "pot-update.txt" .only_default: &only_default only: @@ -101,23 +100,6 @@ test: - build/meson-logs/testlog.txt when: on_failure -test-pot: - image: registry.gitlab.gnome.org/gnome/mutter/master:v4 - stage: test - needs: ["build"] - before_script: - - ninja -C mutter/build install - script: - # Check that pot files are generated correctly: - # https://savannah.gnu.org/bugs/?50920#comment5 - - ninja -C build gnome-shell-pot 2>&1 | awk ' - BEGIN { start=0; } - start==1 { print $0; } - /gnome-shell-pot/ { start=1; } - ' | tee $POT_LOG - - (! grep -q . $POT_LOG) - <<: *only_default - flatpak: stage: build needs: []