From 8538a42943a51765c2a725f4516b3dfd48320b9e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Florian=20M=C3=BCllner?= Date: Wed, 30 Aug 2023 05:44:46 +0200 Subject: [PATCH] windowMenu: Use NONE ornament by default We now hide ornaments by default. As some of the items in the window menu can be checked, that means that they will now shift horizontally, and no longer align with other menu items when checked. That's quite bad, and as the items in question don't form a distinctive group/section, adding back the spacing only to those two items would still look fairly awkward. So revert back to the previous behavior for this particular menu, and default to the NONE ornament. Closes https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/6962 Part-of: --- js/ui/windowMenu.js | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/js/ui/windowMenu.js b/js/ui/windowMenu.js index b003ee556..145722854 100644 --- a/js/ui/windowMenu.js +++ b/js/ui/windowMenu.js @@ -211,6 +211,12 @@ export class WindowMenu extends PopupMenu.PopupMenu { if (!window.can_close()) item.setSensitive(false); } + + addAction(label, callback) { + const item = super.addAction(label, callback); + item.setOrnament(PopupMenu.Ornament.NONE); + return item; + } } export class WindowMenuManager {