isa/gnome-shell
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

notificationDaemon: separate out GtkNotification creation

Browse Source 
This way, source subclasses can easily use a notification subclass
if different functionality is required.

https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/258
This commit is contained in:
Cosimo Cecchi 2018-10-10 17:28:43 -07:00 committed by Florian Müllner
parent ca3f4cfb41
commit 80a7547129
1 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
js/ui/notificationDaemon.js
View File

@ -660,6 +660,10 @@ var GtkNotificationDaemonAppSource = new Lang.Class({
return new FdoApplicationProxy(Gio.DBus.session, this._appId, this._objectPath, callback); return new FdoApplicationProxy(Gio.DBus.session, this._appId, this._objectPath, callback);
}, },
_createNotification(params) {
return new GtkNotificationDaemonNotification(this, params);
},
activateAction(actionId, target) { activateAction(actionId, target) {
this._createApp((app, error) => { this._createApp((app, error) => {
if (error == null) if (error == null)
@ -688,7 +692,7 @@ var GtkNotificationDaemonAppSource = new Lang.Class({
if (this._notifications[notificationId]) if (this._notifications[notificationId])
this._notifications[notificationId].destroy(); this._notifications[notificationId].destroy();
let notification = new GtkNotificationDaemonNotification(this, notificationParams); let notification = this._createNotification(notificationParams);
notification.connect('destroy', () => { notification.connect('destroy', () => {
delete this._notifications[notificationId]; delete this._notifications[notificationId];
}); });