isa/gnome-shell
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

keyboard: Explicitly destroy swipeTracker after emoji panel destruction

Browse Source 
Even though the emoji panel may be destroyed with the OSK, the swipeTracker
that is set up to navigate between pages is left lingering, and handling
events for some gestures in the stage. This results in warnings like:

  JS ERROR: TypeError: this._panel is null
  set delta@resource:///org/gnome/shell/ui/keyboard.js:720:9
  _onSwipeUpdate@resource:///org/gnome/shell/ui/keyboard.js:750:22
  _updateGesture@resource:///org/gnome/shell/ui/swipeTracker.js:670:14
  vfunc_gesture_progress@resource:///org/gnome/shell/ui/swipeTracker.js:288>

on touch interaction after the OSK was shown and dismissed. In order to fix
this, issue explicit destruction of the swipeTracker when the emoji pager
actor is destroyed.

Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/2543>
This commit is contained in:
Carlos Garnacho 2022-11-16 11:22:18 +01:00 committed by Marge Bot
parent 2326721561
commit 7e4f7c7e5b
1 changed files with 9 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
js/ui/keyboard.js
View File

@ -685,6 +685,15 @@ var EmojiPager = GObject.registerClass({
swipeTracker.connect('update', this._onSwipeUpdate.bind(this)); swipeTracker.connect('update', this._onSwipeUpdate.bind(this));
swipeTracker.connect('end', this._onSwipeEnd.bind(this)); swipeTracker.connect('end', this._onSwipeEnd.bind(this));
this._swipeTracker = swipeTracker; this._swipeTracker = swipeTracker;
this.connect('destroy', () => this._onDestroy());
}
_onDestroy() {
if (this._swipeTracker) {
this._swipeTracker.destroy();
delete this._swipeTracker;
}
} }
get delta() { get delta() {