From 772638c78ea57bf4b83ff651968c9341f9518049 Mon Sep 17 00:00:00 2001 From: Giovanni Campagna Date: Thu, 1 Mar 2012 15:53:48 +0100 Subject: [PATCH] ExtensionSystem: fix installing from website loadExtension() fails if the extension object is already created, but the installation dialog was creating a dummy object in the downloading state. Since nothing requires that (and the object is not in the correct format anyway), just kill it. https://bugzilla.gnome.org/show_bug.cgi?id=671134 --- js/ui/extensionSystem.js | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/js/ui/extensionSystem.js b/js/ui/extensionSystem.js index 328e929ee..a5f00233c 100644 --- a/js/ui/extensionSystem.js +++ b/js/ui/extensionSystem.js @@ -430,13 +430,11 @@ const InstallExtensionDialog = new Lang.Class({ }, _onInstallButtonPressed: function(button, event) { - let extension = { uuid: this._uuid, - state: ExtensionState.DOWNLOADING, - error: '' }; + let state = { uuid: this._uuid, + state: ExtensionState.DOWNLOADING, + error: '' }; - ExtensionUtils.extensions[this._uuid] = extension; - - _signals.emit('extension-state-changed', extension); + _signals.emit('extension-state-changed', state); let params = { version_tag: this._version_tag, shell_version: Config.PACKAGE_VERSION,