isa/gnome-shell
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

st: Remove broken parsing of @media rules

Browse Source 
This code didn't even pay attention to the
cur_stmt->kind.media_rule->media_list, and unconditonally considered
each statement in the ->ruleset to be of kind ruleset.  That seems
broken.

(The theme doesn't use any @media queries, and they are unsupported
anyway.)

Fixes https://gitlab.gnome.org/GNOME/gnome-shell/issues/1979
This commit is contained in:
Federico Mena Quintero 2019-12-02 19:57:08 -06:00 committed by Florian Müllner
parent 01c0803a4a
commit 73776508b3
1 changed files with 1 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
src/st/st-theme.c
View File

@ -858,16 +858,6 @@ add_matched_properties (StTheme *a_this,
} }
break; break;
case AT_MEDIA_RULE_STMT:
if (cur_stmt->kind.media_rule
&& cur_stmt->kind.media_rule->rulesets
&& cur_stmt->kind.media_rule->rulesets->kind.ruleset
&& cur_stmt->kind.media_rule->rulesets->kind.ruleset->sel_list)
{
sel_list = cur_stmt->kind.media_rule->rulesets->kind.ruleset->sel_list;
}
break;
case AT_IMPORT_RULE_STMT: case AT_IMPORT_RULE_STMT:
{ {
CRAtImportRule *import_rule = cur_stmt->kind.import_rule; CRAtImportRule *import_rule = cur_stmt->kind.import_rule;
@ -908,6 +898,7 @@ add_matched_properties (StTheme *a_this,
} }
} }
break; break;
case AT_MEDIA_RULE_STMT:
case AT_RULE_STMT: case AT_RULE_STMT:
case AT_PAGE_RULE_STMT: case AT_PAGE_RULE_STMT:
case AT_CHARSET_RULE_STMT: case AT_CHARSET_RULE_STMT: