isa/gnome-shell
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Refactor show()/hide() sequences

Browse Source 
We seem to have a lot of code that does something along the lines of:

    if (condition)
        actor.show();
    else
        actor.hide();

ClutterActor already has such a thing for exactly this purpose: the 'visible'
property. Use it instead of the mess above.

https://bugzilla.gnome.org/show_bug.cgi?id=672272
This commit is contained in:
Jasper St. Pierre
2012-03-16 18:53:14 -04:00
parent e333263fd6
commit 723a1c843a
7 changed files with 19 additions and 74 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
js/ui/status/network.js
View File

@ -707,10 +707,7 @@ const NMDeviceWired = new Lang.Class({
// the device
// we can do it here because addConnection and removeConnection
// both call _createSection at some point
if (this._connections.length <= 1)
this.section.actor.hide();
else
this.section.actor.show();
this.section.actor.visible = this._connections.length <= 1;
},
_createAutomaticConnection: function() {
@ -1038,13 +1035,8 @@ const NMDeviceWireless = new Lang.Class({
},
setEnabled: function(enabled) {
if (enabled) {
this.statusItem.actor.show();
this.section.actor.show();
} else {
this.statusItem.actor.hide();
this.section.actor.hide();
}
this.statusItem.actor.visible = enabled;
this.section.actor.visible = enabled;
},
activate: function() {