isa/gnome-shell
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

messageTray: Don't play sound when banners are disabled

Browse Source 
When support for notification sounds was added, it made some sense
to keep the 'enable-sound' setting independent from 'show-banners'.

However that changed when 'show-banners' was rebranded in the UI as
"Do Not Disturb", as sounds are at least as disturbing as the banners.

https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/2873
This commit is contained in:
Florian Müllner 2020-10-27 01:03:43 +01:00
parent 69516a52c6
commit 709c226fc3
1 changed files with 0 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
js/ui/messageTray.js
View File

@ -784,8 +784,6 @@ var Source = GObject.registerClass({
if (this.policy.showBanners || notification.urgency == Urgency.CRITICAL) if (this.policy.showBanners || notification.urgency == Urgency.CRITICAL)
this.emit('notification-show', notification); this.emit('notification-show', notification);
else
notification.playSound();
} }
notify(propName) { notify(propName) {