isa/gnome-shell
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

theme-node: Fix font family formatting

Browse Source 
Unlike pango_font_description_from_string(),
pango_font_description_set_family() requires a already properly
formatted font family string. The proper format is a comma seperated
list of font families, but we generated a "comma space" separated list.
Passing a incorrectly formatted font family string to pango seems to
cause wierd issues, where the wrong font is sometimes selected.

For example, this fixes a font selection issue on zh_TW.UTF-8 locale for
chinese characters, where previously the "Droid Sans" font was selected
instead of "Source Han Sans TW" even though fontconfig had placed
"Source Han Sans TW" before "Droid Sans".

https://bugzilla.gnome.org/show_bug.cgi?id=786868
This commit is contained in:
Jonas Ådahl 2017-09-04 17:47:35 +08:00
parent 96e14dcbe7
commit 6fc5b0477b
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/st/st-theme-node.c
View File

@ -2576,7 +2576,7 @@ font_family_from_terms (CRTerm *term,
if (term->the_operator == NO_OP) if (term->the_operator == NO_OP)
g_string_append (family_string, " "); g_string_append (family_string, " ");
else else
g_string_append (family_string, ", "); g_string_append (family_string, ",");
} }
else else
{ {