From 6cfcfc72cc11a55b7a59ca2f290f26358889e6d8 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Florian=20M=C3=BCllner?= Date: Mon, 28 Oct 2019 12:32:31 +0100 Subject: [PATCH] panel: Update window section items on title changes We currently only update the windows section when either the focus app changes, or when the app's windows change (that is, a window is opened or closed). This allows the menu item labels to become stale if the window title changes after one of those events (for example when switching tabs). Fix this by updating menu items when the corresponding window title changes. https://gitlab.gnome.org/GNOME/gnome-shell/issues/1830 --- js/ui/panel.js | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/js/ui/panel.js b/js/ui/panel.js index f6ba07d83..437fb8d5d 100644 --- a/js/ui/panel.js +++ b/js/ui/panel.js @@ -170,9 +170,13 @@ class AppMenu extends PopupMenu.PopupMenu { let windows = this._app.get_windows(); windows.forEach(window => { let title = window.title || this._app.get_name(); - this._windowSection.addAction(title, event => { + let item = this._windowSection.addAction(title, event => { Main.activateWindow(window, event.get_time()); }); + let id = window.connect('notify::title', () => { + item.label.text = window.title || this._app.get_name(); + }); + item.connect('destroy', () => window.disconnect(id)); }); } }