isa/gnome-shell
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

workspacesView: Always clip to allocation

Browse Source 
We couldn't clip workspaces views during the overview transition
when we used the "porthole" approach, but as view's allocation
now always matches the expected visible area, we can just apply
the clip unconditionally.

https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/3208
This commit is contained in:
Florian Müllner
2020-08-31 21:11:18 +02:00
parent 432c2863ab
commit 6ce4605c3a
1 changed files with 1 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
js/ui/workspacesView.js
View File

@ -74,6 +74,7 @@ class WorkspacesView extends WorkspacesViewBase {
let workspaceManager = global.workspace_manager; let workspaceManager = global.workspace_manager;
super._init(monitorIndex); super._init(monitorIndex);
this.clip_to_allocation = true;
this._animating = false; // tweening this._animating = false; // tweening
this._gestureActive = false; // touch(pad) gestures this._gestureActive = false; // touch(pad) gestures
@ -96,10 +97,6 @@ class WorkspacesView extends WorkspacesViewBase {
(ws, i) => this.set_child_at_index(ws, i)); (ws, i) => this.set_child_at_index(ws, i));
}); });
this._overviewShownId = Main.overview.connect('shown', () => {
this.clip_to_allocation = true;
});
this._switchWorkspaceNotifyId = this._switchWorkspaceNotifyId =
global.window_manager.connect('switch-workspace', global.window_manager.connect('switch-workspace',
this._activeWorkspaceChanged.bind(this)); this._activeWorkspaceChanged.bind(this));
@ -147,8 +144,6 @@ class WorkspacesView extends WorkspacesViewBase {
} }
animateFromOverview(animationType) { animateFromOverview(animationType) {
this.clip_to_allocation = false;
for (let w = 0; w < this._workspaces.length; w++) { for (let w = 0; w < this._workspaces.length; w++) {
if (animationType == AnimationType.ZOOM) if (animationType == AnimationType.ZOOM)
this._workspaces[w].zoomFromOverview(); this._workspaces[w].zoomFromOverview();
@ -232,7 +227,6 @@ class WorkspacesView extends WorkspacesViewBase {
super._onDestroy(); super._onDestroy();
this._scrollAdjustment.disconnect(this._onScrollId); this._scrollAdjustment.disconnect(this._onScrollId);
Main.overview.disconnect(this._overviewShownId);
global.window_manager.disconnect(this._switchWorkspaceNotifyId); global.window_manager.disconnect(this._switchWorkspaceNotifyId);
let workspaceManager = global.workspace_manager; let workspaceManager = global.workspace_manager;
workspaceManager.disconnect(this._updateWorkspacesId); workspaceManager.disconnect(this._updateWorkspacesId);