isa/gnome-shell
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

windowManager: Update animation of attached modals

Browse Source 
With modal dialogs no longer being attached to their parents'
titlebar, the current animation no longer works too well. Use
a simple fade animation instead.

https://bugzilla.gnome.org/show_bug.cgi?id=674499
This commit is contained in:
Florian Müllner 2012-07-03 22:50:25 +02:00
parent a04350f7ce
commit 6ab25cd791
1 changed files with 5 additions and 21 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
js/ui/windowManager.js
View File

@ -321,28 +321,12 @@ const WindowManager = new Lang.Class({
})); }));
if (actor.meta_window.is_attached_dialog()) { if (actor.meta_window.is_attached_dialog()) {
this._checkDimming(actor.get_meta_window().get_transient_for()); this._checkDimming(actor.get_meta_window().get_transient_for());
if (this._shouldAnimate()) {
actor.set_scale(1.0, 0.0);
actor.show();
this._mapping.push(actor);
Tweener.addTween(actor, if (!this._shouldAnimate()) {
{ scale_y: 1,
time: WINDOW_ANIMATION_TIME,
transition: "easeOutQuad",
onComplete: this._mapWindowDone,
onCompleteScope: this,
onCompleteParams: [shellwm, actor],
onOverwrite: this._mapWindowOverwrite,
onOverwriteScope: this,
onOverwriteParams: [shellwm, actor]
});
return;
}
shellwm.completed_map(actor); shellwm.completed_map(actor);
return; return;
} }
if (!this._shouldAnimateActor(actor)) { } else if (!this._shouldAnimateActor(actor)) {
shellwm.completed_map(actor); shellwm.completed_map(actor);
return; return;
} }
@ -398,7 +382,7 @@ const WindowManager = new Lang.Class({
return; return;
} }
actor.set_scale(1.0, 1.0); actor.opacity = 255;
actor.show(); actor.show();
this._destroying.push(actor); this._destroying.push(actor);
@ -408,7 +392,7 @@ const WindowManager = new Lang.Class({
})); }));
Tweener.addTween(actor, Tweener.addTween(actor,
{ scale_y: 0, { opacity: 0,
time: WINDOW_ANIMATION_TIME, time: WINDOW_ANIMATION_TIME,
transition: "easeOutQuad", transition: "easeOutQuad",
onComplete: this._destroyWindowDone, onComplete: this._destroyWindowDone,