From 6a46d338e7ddfd272f751c422ec27992dd65e954 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Florian=20M=C3=BCllner?= <fmuellner@gnome.org>
Date: Sat, 1 Jul 2023 02:11:37 +0200
Subject: [PATCH] extensions: Provide separate implementations

For the time being this mostly means re-exporting functions
from the shared module. However openPrefs() is now only
available to extensions, and we stop exporting both
getCurrentExtension() and setExtensionManager() to either
extensions or prefs.

Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/2837>
---
 ...g.gnome.Shell.Extensions.src.gresource.xml |  1 +
 js/extensions/extension.js                    | 28 +++++++++++++++++++
 js/extensions/prefs.js                        |  7 +++++
 js/extensions/sharedInternals.js              | 19 -------------
 js/js-resources.gresource.xml                 |  1 +
 5 files changed, 37 insertions(+), 19 deletions(-)
 create mode 100644 js/extensions/extension.js
 create mode 100644 js/extensions/prefs.js

diff --git a/js/dbusServices/org.gnome.Shell.Extensions.src.gresource.xml b/js/dbusServices/org.gnome.Shell.Extensions.src.gresource.xml
index 51042f933..55be1d199 100644
--- a/js/dbusServices/org.gnome.Shell.Extensions.src.gresource.xml
+++ b/js/dbusServices/org.gnome.Shell.Extensions.src.gresource.xml
@@ -7,6 +7,7 @@
     <file>dbusService.js</file>
 
     <file>extensions/sharedInternals.js</file>
+    <file>extensions/prefs.js</file>
 
     <file>misc/config.js</file>
     <file>misc/extensionUtils.js</file>
diff --git a/js/extensions/extension.js b/js/extensions/extension.js
new file mode 100644
index 000000000..125b7a350
--- /dev/null
+++ b/js/extensions/extension.js
@@ -0,0 +1,28 @@
+import {getCurrentExtension} from './sharedInternals.js';
+
+export {
+    getSettings,
+    initTranslations,
+    gettext,
+    ngettext,
+    pgettext
+} from './sharedInternals.js';
+
+/**
+ * Open the preference dialog of the current extension
+ */
+export function openPrefs() {
+    const extension = getCurrentExtension();
+
+    if (!extension)
+        throw new Error('openPrefs() can only be called from extensions');
+
+    try {
+        const extensionManager = imports.ui.main.extensionManager;
+        extensionManager.openExtensionPrefs(extension.uuid, '', {});
+    } catch (e) {
+        if (e.name === 'ImportError')
+            throw new Error('openPrefs() cannot be called from preferences');
+        logError(e, 'Failed to open extension preferences');
+    }
+}
diff --git a/js/extensions/prefs.js b/js/extensions/prefs.js
new file mode 100644
index 000000000..405b8614e
--- /dev/null
+++ b/js/extensions/prefs.js
@@ -0,0 +1,7 @@
+export {
+    getSettings,
+    initTranslations,
+    gettext,
+    ngettext,
+    pgettext
+} from './sharedInternals.js';
diff --git a/js/extensions/sharedInternals.js b/js/extensions/sharedInternals.js
index 0be5dfb55..c2133936c 100644
--- a/js/extensions/sharedInternals.js
+++ b/js/extensions/sharedInternals.js
@@ -177,22 +177,3 @@ export function getSettings(schema) {
 
     return new Gio.Settings({settings_schema: schemaObj});
 }
-
-/**
- * Open the preference dialog of the current extension
- */
-export function openPrefs() {
-    const extension = getCurrentExtension();
-
-    if (!extension)
-        throw new Error('openPrefs() can only be called from extensions');
-
-    try {
-        const extensionManager = imports.ui.main.extensionManager;
-        extensionManager.openExtensionPrefs(extension.uuid, '', {});
-    } catch (e) {
-        if (e.name === 'ImportError')
-            throw new Error('openPrefs() cannot be called from preferences');
-        logError(e, 'Failed to open extension preferences');
-    }
-}
diff --git a/js/js-resources.gresource.xml b/js/js-resources.gresource.xml
index 419ca024f..93d612cc5 100644
--- a/js/js-resources.gresource.xml
+++ b/js/js-resources.gresource.xml
@@ -12,6 +12,7 @@
     <file>gdm/util.js</file>
 
     <file>extensions/sharedInternals.js</file>
+    <file>extensions/extension.js</file>
 
     <file>misc/animationUtils.js</file>
     <file>misc/config.js</file>