isa/gnome-shell
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

status/bluetooth: Indicate progress on toggle

Browse Source 
Turning bluetooth on or off can be very slow ­– 10-15 seconds on
my system – and we currently don't provide any feedback that
something is indeed happening until the state changes at last.

Address this by using the `acquiring` icon when the adapter is
in a transitioning state.

https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/5773

Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/2444>
This commit is contained in:
Florian Müllner 2022-08-23 00:06:42 +02:00 committed by Marge Bot
parent d54dc08a32
commit 6a23e8ee0f
1 changed files with 19 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
js/ui/status/bluetooth.js
View File

@ -178,14 +178,31 @@ class BluetoothToggle extends QuickToggle {
this._client.bind_property('active',
this, 'checked',
GObject.BindingFlags.SYNC_CREATE);
this._client.bind_property_full('active',
this._client.bind_property_full('adapter-state',
this, 'icon-name',
GObject.BindingFlags.SYNC_CREATE,
(bind, source) => [true, source ? 'bluetooth-active-symbolic' : 'bluetooth-disabled-symbolic'],
(bind, source) => [true, this._getIconNameFromState(source)],
null);
this.connect('clicked', () => this._client.toggleActive());
}
_getIconNameFromState(state) {
switch (state) {
case AdapterState.ON:
return 'bluetooth-active-symbolic';
case AdapterState.OFF:
case AdapterState.ABSENT:
return 'bluetooth-disabled-symbolic';
case AdapterState.TURNING_ON:
case AdapterState.TURNING_OFF:
return 'bluetooth-acquiring-symbolic';
default:
console.warn(`Unexpected state ${
GObject.enum_to_string(AdapterState, state)}`);
return '';
}
}
});
var Indicator = GObject.registerClass(