isa/gnome-shell
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

signalTracker: Avoid doing two maps lookups once they're initialized

Browse Source 
Avoid checking if a map contains a value, given that in the case it's
not there, get() will just return an undefined value. And only in such
case we need to set the value.

Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/2366>
This commit is contained in:
Marco Trevisan (Treviño) 2022-07-06 17:44:48 +02:00
parent bb115f11c5
commit 68ceed5c28
1 changed files with 12 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
js/misc/signalTracker.js
View File

@ -50,9 +50,12 @@ class SignalManager {
* @returns {SignalTracker} - the signal tracker for object
*/
getSignalTracker(obj) {
if (!this._signalTrackers.has(obj))
this._signalTrackers.set(obj, new SignalTracker(obj));
return this._signalTrackers.get(obj);
let signalTracker = this._signalTrackers.get(obj);
if (signalTracker === undefined) {
signalTracker = new SignalTracker(obj);
this._signalTrackers.set(obj, signalTracker);
}
return signalTracker;
}
}
@ -80,9 +83,12 @@ class SignalTracker {
* @returns {SignalData} - signal data for object
*/
_getSignalData(obj) {
if (!this._map.has(obj))
this._map.set(obj, { ownerSignals: [], destroyId: 0 });
return this._map.get(obj);
let data = this._map.get(obj);
if (data === undefined) {
data = { ownerSignals: [], destroyId: 0 };
this._map.set(obj, data);
}
return data;
}
/**