From 633dd0d9de3d84234d6c621f3a5e89cd8607e7dd Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Florian=20M=C3=BCllner?= Date: Mon, 28 Oct 2013 11:26:17 +0100 Subject: [PATCH] notificationDaemon: Save notifications on source destruction While the existing comment is correct in that a source's notifications will be destroyed first, the code takes a shortcut which prevents the Source::count-updated signal from being emitted. Given that the purpose of the signal is to keep notification counters up-to-date which is pointless when the source is about to be destroyed, the shortcut makes sense; just save notifications explicitly in that case. https://bugzilla.gnome.org/show_bug.cgi?id=710596 --- js/ui/notificationDaemon.js | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/js/ui/notificationDaemon.js b/js/ui/notificationDaemon.js index 96b147274..d75224f7f 100644 --- a/js/ui/notificationDaemon.js +++ b/js/ui/notificationDaemon.js @@ -905,10 +905,8 @@ const GtkNotificationDaemon = new Lang.Class({ let source = new GtkNotificationDaemonAppSource(appId); source.connect('destroy', Lang.bind(this, function() { - // When a source is destroyed, it should first - // destroy all of its notifications, so we should - // not need to call _saveNotifications here. delete this._sources[appId]; + this._saveNotifications(); })); source.connect('count-updated', Lang.bind(this, this._saveNotifications)); Main.messageTray.add(source);