From 622590179b33e3c4dc4d132fc8129671a397ed07 Mon Sep 17 00:00:00 2001 From: Carlos Garnacho Date: Tue, 23 Aug 2022 18:29:09 +0200 Subject: [PATCH] keyboard: Use the right property to figure out modifiers set size During development of the OSK updates, this._modifiers turned from an array into a Set(), but this location missed switching from length() to size() to get the cardinality of the contained values. As a result, the OSK misbehaved and resorted for key event forwarding for impossible keyvals, instead of handing them directly to the IM. Fixes: https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/5766 Part-of: --- js/ui/keyboard.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/js/ui/keyboard.js b/js/ui/keyboard.js index 4bdac879a..895691c34 100644 --- a/js/ui/keyboard.js +++ b/js/ui/keyboard.js @@ -1511,7 +1511,7 @@ var Keyboard = GObject.registerClass({ if (key.action !== 'modifier') { button.connect('commit', (actor, keyval, str) => { - if (this._modifiers.length === 0 && str !== '' && + if (this._modifiers.size === 0 && str !== '' && keyval && this._oskCompletionEnabled) { Main.inputMethod.handleVirtualKey(keyval); return;