isa/gnome-shell
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

userWidget: Handle non-square icons gracefully

Browse Source 
We currently assume that user icons are square, which is the case when
set by the users settings panel, but not enforced by AccountsService.

Handle that case by moving the pixel size back to the actor and using
an appropriate background-size style property of 'cover' (which means
the smallest dimension of the image is scaled to fit the desired size).

https://gitlab.gnome.org/GNOME/gnome-shell/issues/1144
This commit is contained in:
Florian Müllner 2019-07-10 17:18:16 +02:00 committed by Georges Basile Stavracas Neto
parent 007d305736
commit 5fc456d9d9
1 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
js/ui/userWidget.js
View File

@ -46,9 +46,13 @@ var Avatar = class {
if (iconFile) { if (iconFile) {
this.actor.child = null; this.actor.child = null;
let { scaleFactor } = St.ThemeContext.get_for_stage(global.stage);
this.actor.set_size(
this._iconSize * scaleFactor,
this._iconSize * scaleFactor);
this.actor.style = ` this.actor.style = `
background-image: url("${iconFile}"); background-image: url("${iconFile}");
background-size: ${this._iconSize}px`; background-size: cover;`;
} else { } else {
this.actor.style = null; this.actor.style = null;
this.actor.child = new St.Icon({ icon_name: 'avatar-default-symbolic', this.actor.child = new St.Icon({ icon_name: 'avatar-default-symbolic',