From 5f995c64d4b9af9c2cede2bed530482128a04429 Mon Sep 17 00:00:00 2001 From: "Jasper St. Pierre" Date: Sat, 16 Feb 2013 12:44:04 -0500 Subject: [PATCH] grabHelper: Correct typo preventing focus-window-changed disconnect While debugging, I found that the signal to focus-window-changed was never getting disconnected, making a call to ungrab every time the focus window changed, even if there were no focus grabs anymore. https://bugzilla.gnome.org/show_bug.cgi?id=693975 --- js/ui/grabHelper.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/js/ui/grabHelper.js b/js/ui/grabHelper.js index 0c0e190d5..058524ae8 100644 --- a/js/ui/grabHelper.js +++ b/js/ui/grabHelper.js @@ -232,7 +232,7 @@ const GrabHelper = new Lang.Class({ this._keyFocusNotifyId = 0; } - if (!this._focusWindowChanged > 0) { + if (this._focusWindowChangedId > 0) { let metaDisplay = global.screen.get_display(); metaDisplay.disconnect(this._focusWindowChangedId); this._focusWindowChangedId = 0;