From 5f3f4c3301a0e0dd10e95d4bdd1cff9b1b883327 Mon Sep 17 00:00:00 2001 From: Carlos Garnacho Date: Tue, 21 Jan 2020 16:35:07 +0100 Subject: [PATCH] keyboard: Do not reset to initial page on unmap It will happen before next map anyway, and most notably at times actor sizes produce correct results. Fixes oddities in emoji pager visibility after showing the emoji panel, moving to another page, and hiding the OSK with the downward arrow button. The next time the emoji panel would be shown, panels had a chance to remain invisible. https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/943 --- js/ui/keyboard.js | 5 ----- 1 file changed, 5 deletions(-) diff --git a/js/ui/keyboard.js b/js/ui/keyboard.js index 7f7e8a4e5..3a3296200 100644 --- a/js/ui/keyboard.js +++ b/js/ui/keyboard.js @@ -942,11 +942,6 @@ var EmojiSelection = GObject.registerClass({ super.vfunc_map(); } - vfunc_unmap() { - super.vfunc_unmap(); - this._emojiPager.setCurrentPage(0); - } - _onPageChanged(sectionLabel, page, nPages) { this._curPage = page; this._pageIndicator.setNPages(nPages);