From 5f2bd7069021582d16c6a329ccaeaa269c73a3ac Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Florian=20M=C3=BCllner?= Date: Sat, 2 Mar 2019 20:46:28 +0100 Subject: [PATCH] network: Don't destroy wireless dialog twice The dialog doesn't change the `destroyOnClose` property from its default, so it is already destroyed automatically on close. So if we also destroy it explicitly, we end up (rightfully) with one of gjs' infamous "invalid access" warnings. https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/430 --- js/ui/status/network.js | 1 - 1 file changed, 1 deletion(-) diff --git a/js/ui/status/network.js b/js/ui/status/network.js index 21cbeac61..77a6202b8 100644 --- a/js/ui/status/network.js +++ b/js/ui/status/network.js @@ -1236,7 +1236,6 @@ var NMDeviceWireless = class { } _dialogClosed() { - this._dialog.destroy(); this._dialog = null; }