isa/gnome-shell
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

workspaceAnimation: Fix warning on restacking

Browse Source 
Only workspace groups that are associated with a workspace have a
background. As a result, when restacking window previews we end up
passing `undefined` to clutter_actor_set_child_above_sibling()
instead of null, triggering a warning.

Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/2209>
This commit is contained in:
Florian Müllner 2022-02-22 21:16:52 +01:00 committed by Marge Bot
parent 2b45a01517
commit 5d1b9a429e
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
js/ui/workspaceAnimation.js
View File

@ -73,11 +73,13 @@ class WorkspaceGroup extends Clutter.Actor {
this._shouldShowWindow(w.meta_window)); this._shouldShowWindow(w.meta_window));
let lastRecord; let lastRecord;
const bottomActor = this._background ?? null;
for (const windowActor of windowActors) { for (const windowActor of windowActors) {
const record = this._windowRecords.find(r => r.windowActor === windowActor); const record = this._windowRecords.find(r => r.windowActor === windowActor);
this.set_child_above_sibling(record.clone, lastRecord ? lastRecord.clone : this._background); this.set_child_above_sibling(record.clone,
lastRecord ? lastRecord.clone : bottomActor);
lastRecord = record; lastRecord = record;
} }
} }