From 588dd6d80a844c4130b6f30ff8c5816b3b2a1f4f Mon Sep 17 00:00:00 2001 From: Ray Strode Date: Wed, 28 Apr 2021 10:44:56 -0400 Subject: [PATCH] gdm: Only disconnect verification signals when not going to retry At the moment a failure in a background service can lead to the various verification signals getting disconnected, even though we still need them for a foreground service. This commit changes the code to only disconnect when we've run out of tries. Part-of: --- js/gdm/util.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/js/gdm/util.js b/js/gdm/util.js index cb70c285f..ecaf09b6a 100644 --- a/js/gdm/util.js +++ b/js/gdm/util.js @@ -690,13 +690,13 @@ var ShellUserVerifier = class { // the dialog // Otherwise, when in login mode we allow ALLOWED_FAILURES attempts. // After that, we go back to the welcome screen. - this._disconnectSignals(); - this._filterServiceMessages(serviceName, MessageType.ERROR); const doneTrying = !shouldRetry || !this._canRetry(); if (doneTrying) { + this._disconnectSignals(); + // eslint-disable-next-line no-lonely-if if (!this.hasPendingMessages) { this._cancelAndReset();