isa/gnome-shell
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

extensionUtils: Add DISABLING and ENABLING extension states

Browse Source 
Extensions can export asynchronous enable() and disable()
functions. To guard against re-entrancy when enabling or
disabling an extension, this commit adds two new states:
ENABLING and DISABLING which are set immediately prior
to calling enable() and disable() respectively.

This commit updates the extensions CLI and Extensions app
with new strings for these states.

Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/2364>
This commit is contained in:
Evan Welsh
2022-07-24 19:25:23 -07:00
committed by Marge Bot
parent b7c097ba79
commit 56beb6ff2b
6 changed files with 25 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
js/ui/extensionSystem.js
View File

@ -100,6 +100,9 @@ var ExtensionManager = class extends Signals.EventEmitter {
if (extension.state != ExtensionState.ENABLED)
return;
extension.state = ExtensionState.DISABLING;
this.emit('extension-state-changed', extension);
// "Rebase" the extension order by disabling and then enabling extensions
// in order to help prevent conflicts.
@ -164,6 +167,9 @@ var ExtensionManager = class extends Signals.EventEmitter {
if (extension.state != ExtensionState.DISABLED)
return;
extension.state = ExtensionState.ENABLING;
this.emit('extension-state-changed', extension);
let stylesheetNames = [`${global.session_mode}.css`, 'stylesheet.css'];
let theme = St.ThemeContext.get_for_stage(global.stage).get_theme();
for (let i = 0; i < stylesheetNames.length; i++) {