isa/gnome-shell
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

screenshot: Only select area on button release after a button down

Browse Source 
On Wayland it is possible to trigger area selection with a button
already being down. SelectArea would then react to the subsequent button
release without ever having seen a corresponding button down first,
leaving the start coordinates of the selection rectangle uninitialized.

Related: https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/2761
Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/1825>
This commit is contained in:
Sebastian Keller 2021-04-28 07:13:35 +02:00 committed by Marge Bot
parent 82c2f293a0
commit 548e18ad7e
1 changed files with 3 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
js/ui/screenshot.js
View File

@ -393,6 +393,9 @@ class SelectArea extends St.Widget {
} }
vfunc_button_release_event() { vfunc_button_release_event() {
if (this._startX === -1 || this._startY === -1)
return Clutter.EVENT_PROPAGATE;
this._result = this._getGeometry(); this._result = this._getGeometry();
this.ease({ this.ease({
opacity: 0, opacity: 0,