isa/gnome-shell
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

app-display: Escape categories in filter labels

Browse Source 
As gnome-shell now switched to use the menu file from gnome-menus,
we no longer have direct control over category names. If such a name
contains unescaped markup, the shell will crash when trying to create
the filter label, so make sure to escape markup in category names.
This commit is contained in:
Florian Müllner 2011-02-25 17:50:39 +01:00
parent 9915038e9b
commit 5137cee3d6
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
js/ui/appDisplay.js
View File

@ -1,6 +1,7 @@
/* -*- mode: js2; js2-basic-offset: 4; indent-tabs-mode: nil -*- */ /* -*- mode: js2; js2-basic-offset: 4; indent-tabs-mode: nil -*- */
const Clutter = imports.gi.Clutter; const Clutter = imports.gi.Clutter;
const GLib = imports.gi.GLib;
const Gtk = imports.gi.Gtk; const Gtk = imports.gi.Gtk;
const Shell = imports.gi.Shell; const Shell = imports.gi.Shell;
const Lang = imports.lang; const Lang = imports.lang;
@ -143,7 +144,7 @@ ViewByCategories.prototype = {
}, },
_addFilter: function(name, num) { _addFilter: function(name, num) {
let button = new St.Button({ label: name, let button = new St.Button({ label: GLib.markup_escape_text (name, -1),
style_class: 'app-filter', style_class: 'app-filter',
x_align: St.Align.START }); x_align: St.Align.START });
this._filters.add(button, { expand: true, x_fill: true, y_fill: false }); this._filters.add(button, { expand: true, x_fill: true, y_fill: false });