From 4e84b46c9b96f33d5e5d6fac4b70e1bc6403783a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Marco=20Trevisan=20=28Trevi=C3=B1o=29?= Date: Wed, 19 Jun 2019 00:24:01 +0200 Subject: [PATCH] keyboard: Add extended keys and language popups to top window group As per commit 2bd80579ed important actors are added to the top window group using the layout's addTopChrome method. This group includes the on-screen keyboard, however its popups were not added and so they are now shown under the OSK and don't receive any input. Fix this by adding Language popup and extended keys popup to top chrome. Fixes https://gitlab.gnome.org/GNOME/gnome-shell/issues/1396 https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/583 --- js/ui/keyboard.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/js/ui/keyboard.js b/js/ui/keyboard.js index b57aeec0c..b6a26663a 100644 --- a/js/ui/keyboard.js +++ b/js/ui/keyboard.js @@ -282,7 +282,7 @@ var Key = class Key { y_fill: true, x_align: St.Align.START }); this._boxPointer.hide(); - Main.layoutManager.addChrome(this._boxPointer); + Main.layoutManager.addTopChrome(this._boxPointer); this._boxPointer.setPosition(this.keyButton, 0.5); // Adds style to existing keyboard style to avoid repetition @@ -1306,7 +1306,7 @@ var Keyboard = class Keyboard { this._languagePopup.destroy(); this._languagePopup = new LanguageSelectionPopup(keyActor); - Main.layoutManager.addChrome(this._languagePopup.actor); + Main.layoutManager.addTopChrome(this._languagePopup.actor); this._languagePopup.open(true); }