isa/gnome-shell
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

messageTray: Disable unredirection while showing banners

Browse Source 
We don't usually show notification banners while the monitor is in
fullscreen, but when we do - the notification is urgent - we should
actually show the banner, even if the top-most window is unredirected.
To achieve that, disable unredirection while the banner is showing.

https://gitlab.gnome.org/GNOME/gnome-shell/issues/430
This commit is contained in:
Florian Müllner 2018-08-13 01:25:13 +02:00 committed by Florian Müllner
parent f1195ecb01
commit 4dc2039859
1 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
js/ui/messageTray.js
View File

@ -1295,8 +1295,10 @@ var MessageTray = new Lang.Class({
}
this._banner = this._notification.createBanner();
this._bannerClickedId = this._banner.connect('done-displaying',
this._escapeTray.bind(this));
this._bannerClickedId = this._banner.connect('done-displaying', () => {
Meta.enable_unredirect_for_display(global.display);
this._escapeTray();
});
this._bannerUnfocusedId = this._banner.connect('unfocused', () => {
this._updateState();
});
@ -1308,6 +1310,7 @@ var MessageTray = new Lang.Class({
this._bannerBin.y = -this._banner.actor.height;
this.actor.show();
Meta.disable_unredirect_for_display(global.display);
this._updateShowingNotification();
let [x, y, mods] = global.get_pointer();