isa/gnome-shell
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

searchDisplay: Improve the placement and style of the "No results" text

Browse Source 
During user testing, it was shown that several people did not notice the
miniscule text label. Make it large and centered.

https://bugzilla.gnome.org/show_bug.cgi?id=683135
This commit is contained in:
Jasper St. Pierre 2012-08-31 14:27:35 -03:00
parent f8805e8311
commit 4ba1f26e4d
2 changed files with 16 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
data/theme/gnome-shell.css
View File

@ -695,7 +695,6 @@ StButton.popup-menu-item:insensitive {
padding-left: 20px; padding-left: 20px;
} }
.search-statustext,
.search-section-header { .search-section-header {
padding: 4px 12px; padding: 4px 12px;
spacing: 4px; spacing: 4px;
@ -703,6 +702,12 @@ StButton.popup-menu-item:insensitive {
font-size: .8em; font-size: .8em;
} }
.search-statustext {
color: #efefef;
font-size: 2em;
font-weight: bold;
}
.search-section-results { .search-section-results {
padding: 6px; padding: 6px;
} }

17
js/ui/searchDisplay.js
View File

@ -190,7 +190,7 @@ const SearchResults = new Lang.Class({
scrollView.add_actor(this._content); scrollView.add_actor(this._content);
this.actor.add(scrollView, { x_fill: true, this.actor.add(scrollView, { x_fill: true,
y_fill: false, y_fill: true,
expand: true, expand: true,
x_align: St.Align.START, x_align: St.Align.START,
y_align: St.Align.START }); y_align: St.Align.START });
@ -205,7 +205,10 @@ const SearchResults = new Lang.Class({
})); }));
this._statusText = new St.Label({ style_class: 'search-statustext' }); this._statusText = new St.Label({ style_class: 'search-statustext' });
this._content.add(this._statusText); this._statusBin = new St.Bin({ x_align: St.Align.MIDDLE,
y_align: St.Align.MIDDLE });
this._content.add(this._statusBin, { expand: true });
this._statusBin.add_actor(this._statusText);
this._providers = this._searchSystem.getProviders(); this._providers = this._searchSystem.getProviders();
this._providerMeta = []; this._providerMeta = [];
for (let i = 0; i < this._providers.length; i++) { for (let i = 0; i < this._providers.length; i++) {
@ -265,14 +268,14 @@ const SearchResults = new Lang.Class({
reset: function() { reset: function() {
this._searchSystem.reset(); this._searchSystem.reset();
this._statusText.hide(); this._statusBin.hide();
this._clearDisplay(); this._clearDisplay();
}, },
startingSearch: function() { startingSearch: function() {
this.reset(); this.reset();
this._statusText.set_text(_("Searching...")); this._statusText.set_text(_("Searching..."));
this._statusText.show(); this._statusBin.show();
}, },
doSearch: function (searchString) { doSearch: function (searchString) {
@ -322,10 +325,10 @@ const SearchResults = new Lang.Class({
} }
if (!haveResults) { if (!haveResults) {
this._statusText.set_text(_("No matching results.")); this._statusText.set_text(_("No results."));
this._statusText.show(); this._statusBin.show();
} else { } else {
this._statusText.hide(); this._statusBin.hide();
} }
}, },