ShellApp: Change activation API

Since almost all of the callers of shell_app_activate were using the
default workspace (by passing -1), remove that parameter.

Add a new shell_app_activate_full() API which takes a workspace as
well as a timestamp; previously we might have been ignoring event
timestamps from elsewhere.

https://bugzilla.gnome.org/show_bug.cgi?id=648149

js/ui/status/accessibility.js

@@ -91,7 +91,7 @@ ATIndicator.prototype = {
         this.menu.addAction(_("Universal Access Settings"), function() {
             Main.overview.hide();
             let app = Shell.AppSystem.get_default().lookup_setting('gnome-universal-access-panel.desktop');
-            app.activate(-1);
+            app.activate();
         });
     },
 

js/ui/status/bluetooth.js

@@ -92,7 +92,7 @@ Indicator.prototype = {
         this.menu.addAction(_("Bluetooth Settings"), function() {
             Main.overview.hide()
             let app = Shell.AppSystem.get_default().lookup_setting('bluetooth-properties.desktop');
-            app.activate(-1);
+            app.activate();
         });
 
         this._applet.connect('pincode-request', Lang.bind(this, this._pinRequest));

js/ui/status/keyboard.js

@@ -75,7 +75,7 @@ XKBIndicator.prototype = {
         this.menu.addAction(_("Region and Language Settings"), function() {
             Main.overview.hide();
             let app = Shell.AppSystem.get_default().lookup_setting('gnome-region-panel.desktop');
-            app.activate(-1);
+            app.activate();
         });
     },
 

js/ui/status/network.js

@@ -1605,7 +1605,7 @@ NMApplet.prototype = {
         this.menu.addAction(_("Network Settings"), function() {
             Main.overview.hide();
             let app = Shell.AppSystem.get_default().lookup_setting('gnome-network-panel.desktop');
-            app.activate(-1);
+            app.activate();
         });
 
         this._activeConnections = [ ];

js/ui/status/power.js

@@ -83,7 +83,7 @@ Indicator.prototype = {
         this.menu.addAction(_("Power Settings"),function() {
             Main.overview.hide();
             let app = Shell.AppSystem.get_default().lookup_setting('gnome-power-panel.desktop');
-            app.activate(-1);
+            app.activate();
         });
 
         this._proxy.connect('Changed', Lang.bind(this, this._devicesChanged));

js/ui/status/volume.js

@@ -64,7 +64,7 @@ Indicator.prototype = {
         this.menu.addAction(_("Sound Settings"), function() {
             Main.overview.hide();
             let app = Shell.AppSystem.get_default().lookup_setting('gnome-sound-panel.desktop');
-            app.activate(-1);
+            app.activate();
         });
 
         this.actor.connect('scroll-event', Lang.bind(this, this._onScrollEvent));