isa/gnome-shell
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Improve comments about startup notification

Browse Source 
Do a better job at describe the problems in docDisplay.js related
to not reading the desktop files and finding StartupNotify=true.
Also, fix a typo.

http://bugzilla.gnome.org/show_bug.cgi?id=580658
This commit is contained in:
Owen W. Taylor 2009-05-01 16:21:00 -04:00
parent bb69afc830
commit 4664fac566
2 changed files with 7 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
js/ui/docDisplay.js
View File

@ -80,10 +80,12 @@ DocDisplayItem.prototype = {
let appInfo = Gio.app_info_create_from_commandline(appExec, null, 0, null); let appInfo = Gio.app_info_create_from_commandline(appExec, null, 0, null);
// The app launch context doesn't work as well as we might like because // The point of passing an app launch context to launch() is mostly to get
// it doesn't get the right StartupNotify key from the application's // startup notification and associated benefits like the app appearing
// desktop file. So, we don't get startup notification, the application // on the right desktop; but it doesn't really work for now because we aren't
// doesn't stick to the current workspace, and so forth. // reading the application's desktop file, and thus don't find the
// StartupNotify=true in it. So, despite passing the app launch context,
// no startup notification occurs.
appInfo.launch([], Main.create_app_launch_context()); appInfo.launch([], Main.create_app_launch_context());
} else { } else {
log("Failed to get application info for " + this._docInfo.get_uri()); log("Failed to get application info for " + this._docInfo.get_uri());

2
js/ui/main.js
View File

@ -176,7 +176,7 @@ function create_app_launch_context() {
context.set_timestamp(display.get_current_time()); context.set_timestamp(display.get_current_time());
// Make sure that the app is opened on the current workspace even if // Make sure that the app is opened on the current workspace even if
// the user switches before it seetarts // the user switches before it starts
context.set_desktop(screen.get_active_workspace_index()); context.set_desktop(screen.get_active_workspace_index());
return context; return context;