diff --git a/src/st/st-texture-cache.c b/src/st/st-texture-cache.c index 281241ade..e8a832df0 100644 --- a/src/st/st-texture-cache.c +++ b/src/st/st-texture-cache.c @@ -448,6 +448,8 @@ load_pixbuf_thread (GTask *result, g_task_return_error (result, error); else if (pixbuf) g_task_return_pointer (result, g_object_ref (pixbuf), g_object_unref); + + g_clear_object (&pixbuf); } static GdkPixbuf * @@ -1038,18 +1040,22 @@ on_sliced_image_loaded (GObject *source_object, GObject *cache = source_object; AsyncImageData *data = (AsyncImageData *)user_data; GTask *task = G_TASK (res); - GList *list; + GList *list, *pixbufs; if (g_task_had_error (task)) return; - for (list = g_task_propagate_pointer (task, NULL); list; list = list->next) + pixbufs = g_task_propagate_pointer (task, NULL); + + for (list = pixbufs; list; list = list->next) { ClutterActor *actor = load_from_pixbuf (GDK_PIXBUF (list->data)); clutter_actor_hide (actor); clutter_actor_add_child (data->actor, actor); } + g_list_free_full (pixbufs, g_object_unref); + if (data->load_callback != NULL) data->load_callback (cache, data->load_callback_data); } @@ -1057,12 +1063,7 @@ on_sliced_image_loaded (GObject *source_object, static void free_glist_unref_gobjects (gpointer p) { - GList *list = p; - GList *iter; - - for (iter = list; iter; iter = iter->next) - g_object_unref (iter->data); - g_list_free (list); + g_list_free_full (p, g_object_unref); } static void