panel: Don't change text color when entering the overview or lockscreen
With the introduction of the transparent panel in the overview, we started making the panel text/icon color slightly brighter in the overview and on the lockscreen to ensure best contrast. Now unfortunately, setting the text color incurred a relayout of the underlying ClutterText actor (fixed with https://gitlab.gnome.org/GNOME/mutter/-/merge_requests/1750), and setting the icon color causes the icon texture to get regenerated (fixed with https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/932). Regenerating the icon texture will replace the icon actor, which also causes a relayout. This relayout of the panel has been measured to add at least 1 millisecond (the numbers fluctuated a lot) to about 5 ms it takes to layout the first frame when showing the overview. Since https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/932 is unlikely to land this cycle, this commit proposes a different solution: Simply don't use a different color for text in the overview. To avoid issues with contrast in the overview, make the default color slightly brighter and change it from #ccc to #ddd. Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/1733>
This commit is contained in:
parent
5de9166f7a
commit
3eb40df06b
@ -3,7 +3,7 @@
|
||||
|
||||
$panel_corner_radius: $base_border_radius+1;
|
||||
$panel_bg_color: #000;
|
||||
$panel_fg_color: #ccc;
|
||||
$panel_fg_color: #ddd;
|
||||
$panel_height: 2.2em;
|
||||
$panel_transition_duration: 250ms; // same as the overview transition duration
|
||||
|
||||
@ -99,8 +99,6 @@ $panel_transition_duration: 250ms; // same as the overview transition duration
|
||||
&.login-screen,
|
||||
&:overview {
|
||||
.panel-button {
|
||||
color: lighten($fg_color, 3%);
|
||||
|
||||
&:hover, &:active, &:overview, &:focus, &:checked {
|
||||
box-shadow: inset 0 0 0 100px rgba(255, 255, 255, 0.15);
|
||||
|
||||
|
Loading…
Reference in New Issue
Block a user