isa/gnome-shell
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

st-icon: Fix memory leak

Browse Source 
We were never freeing the dup'd icon_name string for an StIcon.
This commit is contained in:
Jasper St. Pierre 2011-12-18 23:30:26 -05:00 committed by Owen W. Taylor
parent 3bf11dbd31
commit 3d3494a15b
1 changed files with 15 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
src/st/st-icon.c
View File

@ -174,6 +174,20 @@ st_icon_dispose (GObject *gobject)
G_OBJECT_CLASS (st_icon_parent_class)->dispose (gobject); G_OBJECT_CLASS (st_icon_parent_class)->dispose (gobject);
} }
static void
st_icon_finalize (GObject *object)
{
StIconPrivate *priv = ST_ICON (gobject)->priv;
if (priv->icon_name)
{
g_free (priv->icon_name);
priv->icon_name = NULL;
}
G_OBJECT_CLASS (st_icon_parent_class)->finalize (gobject);
}
static void static void
st_icon_get_preferred_height (ClutterActor *actor, st_icon_get_preferred_height (ClutterActor *actor,
gfloat for_width, gfloat for_width,
@ -317,6 +331,7 @@ st_icon_class_init (StIconClass *klass)
object_class->get_property = st_icon_get_property; object_class->get_property = st_icon_get_property;
object_class->set_property = st_icon_set_property; object_class->set_property = st_icon_set_property;
object_class->dispose = st_icon_dispose; object_class->dispose = st_icon_dispose;
object_class->finalize = st_icon_finalize;
actor_class->get_preferred_height = st_icon_get_preferred_height; actor_class->get_preferred_height = st_icon_get_preferred_height;
actor_class->get_preferred_width = st_icon_get_preferred_width; actor_class->get_preferred_width = st_icon_get_preferred_width;