From 35c85d9faca4a5906ba583c5a3f60201813607c6 Mon Sep 17 00:00:00 2001 From: Nohemi Fernandez Date: Thu, 7 Apr 2011 19:10:24 -0400 Subject: [PATCH] Fix search handling when typing multiple searches in the search box In the current implementation of the search entry, when replacing a selected search term with another term, the first character of the replacement is prepended to the hint text rather than starting a new search. This fix makes sure that the focus is not lost when changing the selected search term. https://bugzilla.gnome.org/show_bug.cgi?id=636341 --- js/ui/viewSelector.js | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/js/ui/viewSelector.js b/js/ui/viewSelector.js index 00ec8a408..29262dcf3 100644 --- a/js/ui/viewSelector.js +++ b/js/ui/viewSelector.js @@ -162,7 +162,14 @@ SearchTab.prototype = { hide: function() { BaseTab.prototype.hide.call(this); - this._reset(); + // Leave the entry focused when it doesn't have any text; + // when replacing a selected search term, Clutter emits + // two 'text-changed' signals, one for deleting the previous + // text and one for the new one - the second one is handled + // incorrectly when we remove focus + // (https://bugzilla.gnome.org/show_bug.cgi?id=636341) */ + if (this._text.text != '') + this._reset(); }, _reset: function () {