NetworkAgent: Fix double-unref in get_secrets_keyring_cb()

In get_secrets_keyring_cb, we own a ref on the 'attributes' hash table
from secret_item_get_attributes), and a ref on the 'secret' object (from
secret_item_get_secret(), but in the SHELL_KEYRING_SK_TAG case, we unref
these once before breaking out of the loop, and the second time after
breaking out of the loop.

https://bugzilla.gnome.org/show_bug.cgi?id=759708

Note: This is needed to avoid crashes with libsecret 0.18.4 -- Michael
This commit is contained in:
Christophe Fergeau 2015-12-20 20:51:52 +01:00 committed by Michael Catanzaro
parent cdc9652f5b
commit 358ee88e1c

View File

@ -315,8 +315,6 @@ get_secrets_keyring_cb (GObject *source,
secrets_found = TRUE;
g_hash_table_unref (attributes);
secret_value_unref (secret);
break;
}
}