isa/gnome-shell
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

appDisplay: Call super.vfunc_unmap last

Browse Source 
So as to guarantee the unmapped state sticks and doesn't get toggled
back to mapped before we return.

Being in a mapped state when `FolderIcon.vfunc_unmap()` returned was
causing an assertion failure in `clutter_actor_set_mapped` and crashed
the shell.

Closes: https://gitlab.gnome.org/GNOME/gnome-shell/issues/2170
This commit is contained in:
Daniel van Vugt 2020-02-07 17:57:19 +08:00 committed by Florian Müllner
parent 6ec996e45b
commit 33ae220ad2
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
js/ui/appDisplay.js
View File

@ -1525,10 +1525,10 @@ var FolderIcon = GObject.registerClass({
} }
vfunc_unmap() { vfunc_unmap() {
super.vfunc_unmap();
if (this._dialog) if (this._dialog)
this._dialog.popdown(); this._dialog.popdown();
super.vfunc_unmap();
} }
open() { open() {