isa/gnome-shell
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

keyboard: Ensure chrome input region is updated after slide animation

Browse Source 
The keyboard is placed outside of the screen when shown and then slides
in via a transition that changes the translate-y property. This
translation does not affect the allocation of the Keyboard actor and as
such does not trigger any of the signals LayoutManager is connected to
to update the input region. This means the input region remains at the
original position of the actor outside of the screen and as a result on
X11 clicks will go through to the underlying window.

There was a workaround for this by queuing a relayout at the end of the
transition, but this stopped working due to optimizations avoiding
unnecessary allocation changes.

This updates that workaround to toggle the visibility of the actor
instead, which is the other signal that LayoutManager reacts to. Once
ClutterActor provides better ways to react to transforms this can
hopefully be removed entirely.

Fixes: https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/4556
Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/1955>
This commit is contained in:
Sebastian Keller 2021-08-18 00:45:16 +02:00
parent 07579f05f6
commit 2ee323e37e
1 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
js/ui/keyboard.js
View File

@ -1874,8 +1874,11 @@ var Keyboard = GObject.registerClass({
this.translation_y = -this.height;
});
// Queue a relayout so the keyboardBox can update its chrome region.
keyboardBox.queue_relayout();
// Toggle visibility so the keyboardBox can update its chrome region.
if (!Meta.is_wayland_compositor()) {
keyboardBox.hide();
keyboardBox.show();
}
}
_animateHide() {