isa/gnome-shell
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

status/network: Use NM connectivity check URI for Portal Helper

Browse Source 
NetworkManager can check if a network interface has "internet access" by
invoking a HTTP request.

The URI used for connectivity checking in NetworkManager can be configured
manually in NetworkManager.conf:

[connectivity]
uri=http://portal-check.exmaple.com/nm-check.txt

Portal Helper provides an argument to pass the URI that should be opened.
If this argument is empty it uses http://nmcheck.gnome.org as a fallback.

Pass the URI configured in NetworkManager to Portal Helper instead of
an empty string.

Fixes #1313

Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/2228>
This commit is contained in:
Clerie Riese 2022-03-06 16:02:52 +01:00 committed by Marge Bot
parent 4f3b1c51cf
commit 2d6b21357d
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
js/ui/status/network.js
View File

@ -2060,7 +2060,7 @@ class Indicator extends SystemIndicator {
} }
} }
this._portalHelperProxy?.AuthenticateAsync(path, '', timestamp).catch(logError); this._portalHelperProxy?.AuthenticateAsync(path, this._client.connectivity_check_uri, timestamp).catch(logError);
this._connectivityQueue.add(path); this._connectivityQueue.add(path);
} }