isa/gnome-shell
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

messageTray: Always destroy banners when done displaying

Browse Source 
Special-casing banners of resident notifications was really a
thinly veiled special case for chat notifications, as those were
still using the old notification actor which coupled the life-time
of the notification to its actor. This is no longer the case, so
we can do the sane thing and destroy banners once they are no
longer needed.

https://bugzilla.gnome.org/show_bug.cgi?id=746343
This commit is contained in:
Florian Müllner 2015-03-11 17:25:25 +01:00
parent 54f46e8486
commit 2d4ba30ba2
1 changed files with 1 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
js/ui/messageTray.js
View File

@ -2091,9 +2091,6 @@ const MessageTray = new Lang.Class({
this._pointerInNotification = false; this._pointerInNotification = false;
this._notificationRemoved = false; this._notificationRemoved = false;
if (notification.resident)
this._bannerBin.remove_actor(this._banner.actor);
else
this._banner.actor.destroy(); this._banner.actor.destroy();
this._banner = null; this._banner = null;
this.actor.hide(); this.actor.hide();