From 2d2020a20d8f4622b9acea6b15eb645b8580693c Mon Sep 17 00:00:00 2001 From: Ray Strode Date: Thu, 9 Jan 2014 10:42:08 -0500 Subject: [PATCH] loginDialog: defer loading user list until idle In some cases we load the user list after going back to main loop and in other cases we load the user list right away (depending on if accounts service is ready). In the case we load the user list right away we cause a traceback because loading the user list forces a reset, which then tries to reset actors which aren't instantiated yet. This commit ensures the user list is loaded after the constructor finishes and the event loop runs irregardless of the accountsservice state. https://bugzilla.gnome.org/show_bug.cgi?id=721868 --- js/gdm/loginDialog.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/js/gdm/loginDialog.js b/js/gdm/loginDialog.js index d0928f6bd..49ca5ea5a 100644 --- a/js/gdm/loginDialog.js +++ b/js/gdm/loginDialog.js @@ -464,7 +464,7 @@ const LoginDialog = new Lang.Class({ } })); else - this._loadUserList(); + GLib.idle_add(GLib.PRIORITY_DEFAULT, Lang.bind(this, this._loadUserList)); this._userList.connect('activate', Lang.bind(this, function(userList, item) {