isa/gnome-shell
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

NetworkMenu: sort connections by name only

Browse Source 
We don't watch for timestamp changes, and sorting by name keeps
the order consistent and predictable. In practice, there should
be at most 3 or 4 elements, so the user will always read all them
at once and sorting is irrelevant.

https://bugzilla.gnome.org/show_bug.cgi?id=723570
This commit is contained in:
Giovanni Campagna 2014-02-08 14:33:32 +01:00
parent 488a42696c
commit 2bb3aed729
1 changed files with 1 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
js/ui/status/network.js
View File

@ -249,10 +249,7 @@ const NMConnectionSection = new Lang.Class({
}, },
_connectionSortFunction: function(one, two) { _connectionSortFunction: function(one, two) {
if (one._timestamp == two._timestamp) return GLib.utf8_collate(one.get_id(), two.get_id());
return GLib.utf8_collate(one.get_id(), two.get_id());
return two._timestamp - one._timestamp;
}, },
_makeConnectionItem: function(connection) { _makeConnectionItem: function(connection) {
@ -1788,7 +1785,6 @@ const NMApplet = new Lang.Class({
let connectionSettings = connection.get_setting_by_name(NetworkManager.SETTING_CONNECTION_SETTING_NAME); let connectionSettings = connection.get_setting_by_name(NetworkManager.SETTING_CONNECTION_SETTING_NAME);
connection._type = connectionSettings.type; connection._type = connectionSettings.type;
connection._section = this._ctypes[connection._type] || NMConnectionCategory.INVALID; connection._section = this._ctypes[connection._type] || NMConnectionCategory.INVALID;
connection._timestamp = connectionSettings.timestamp;
let section = connection._section; let section = connection._section;