js: Add missing chain-ups in vfuncs

Commit 55b57421d changed signal handlers to the corresponding vfuncs,
but didn't always chain up as necessary. In most places this doesn't
matter, but at the very least the commit broke activating message list
items via the keyboard.

Add all (hopefully) the missing chain-ups to get the expected behavior
back.

https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/2319
This commit is contained in:
Florian Müllner 2020-03-26 23:40:38 +01:00
parent 01a57206bc
commit 26ffeaae47
7 changed files with 7 additions and 6 deletions

View File

@ -120,7 +120,7 @@ var AuthPrompt = GObject.registerClass({
vfunc_key_press_event(keyPressEvent) { vfunc_key_press_event(keyPressEvent) {
if (keyPressEvent.keyval == Clutter.KEY_Escape) if (keyPressEvent.keyval == Clutter.KEY_Escape)
this.cancel(); this.cancel();
return Clutter.EVENT_PROPAGATE; return super.vfunc_key_press_event(keyPressEvent);
} }
_initEntryRow() { _initEntryRow() {

View File

@ -177,6 +177,7 @@ var UserList = GObject.registerClass({
} }
vfunc_key_focus_in() { vfunc_key_focus_in() {
super.vfunc_key_focus_in();
this._moveFocusToItems(); this._moveFocusToItems();
} }

View File

@ -1127,7 +1127,7 @@ class LookingGlass extends St.BoxLayout {
else if (symbol == Clutter.KEY_Page_Down) else if (symbol == Clutter.KEY_Page_Down)
this._notebook.nextTab(); this._notebook.nextTab();
} }
return Clutter.EVENT_PROPAGATE; return super.vfunc_key_press_event(keyPressEvent);
} }
open() { open() {

View File

@ -530,7 +530,7 @@ var Message = GObject.registerClass({
this.close(); this.close();
return Clutter.EVENT_STOP; return Clutter.EVENT_STOP;
} }
return Clutter.EVENT_PROPAGATE; return super.vfunc_key_press_event(keyEvent);
} }
}); });

View File

@ -964,7 +964,7 @@ class Panel extends St.Widget {
return Clutter.EVENT_STOP; return Clutter.EVENT_STOP;
} }
return Clutter.EVENT_PROPAGATE; return super.vfunc_key_press_event(keyEvent);
} }
_toggleMenu(indicator) { _toggleMenu(indicator) {

View File

@ -186,7 +186,7 @@ var Slider = GObject.registerClass({
this.value = Math.max(0, Math.min(this._value + delta, this._maxValue)); this.value = Math.max(0, Math.min(this._value + delta, this._maxValue));
return Clutter.EVENT_STOP; return Clutter.EVENT_STOP;
} }
return Clutter.EVENT_PROPAGATE; return super.vfunc_key_press_event(keyPressEvent);
} }
_moveHandle(absX, _absY) { _moveHandle(absX, _absY) {

View File

@ -404,7 +404,7 @@ var WindowClone = GObject.registerClass({
return true; return true;
} }
return false; return super.key_press_event(keyEvent);
} }
_onClicked() { _onClicked() {