isa/gnome-shell
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

polkitAgent: Ensure cleanup if dialog wasn't shown

Browse Source 
It is possible for an initiated session to complete without
a request if polkit can authenticate the action without user
input. We fail to clean up after ourselves in that case, as
the cleanup is done after the dialog is closed.

The dialog can still be shown when the code that hides existing
dialogs while the screen is locked shows it on unlock. But as
the session was closed, the dialog is now defunct and cannot
be dismissed by the user.

Fix this by running the cleanup on close() when the dialog
wasn't shown.

https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/3701

Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/1662>
This commit is contained in:
Florian Müllner 2021-02-10 00:10:03 +01:00
parent 9fcbf3d0f9
commit 21faae480e
1 changed files with 7 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
js/ui/components/polkitAgent.js
View File

@ -380,6 +380,13 @@ var AuthenticationDialog = GObject.registerClass({
} }
} }
close(timestamp) {
// Ensure cleanup if the dialog was never shown
if (this.state === ModalDialog.State.CLOSED)
this._onDialogClosed();
super.close(timestamp);
}
cancel() { cancel() {
this.close(global.get_current_time()); this.close(global.get_current_time());
this._emitDone(true); this._emitDone(true);