isa/gnome-shell
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Suppress animation for titles in overview

Browse Source 
Because of the animation and collision with relayout, the title of windows in overview may not appear, mainly
the first time we enter in overview

With an animation delay of 0.1s, you'll not see the difference

https://bugzilla.gnome.org/show_bug.cgi?id=709392
This commit is contained in:
Sebastien Lafargue 2013-10-03 23:08:59 +02:00 committed by Adel Gadllah
parent a21c0097c2
commit 20c18c1fc0
1 changed files with 4 additions and 22 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

26
js/ui/workspace.js
View File

@ -343,19 +343,6 @@ const WindowOverlay = new Lang.Class({
this._animateVisible(); this._animateVisible();
}, },
fadeIn: function() {
if (!this._hidden)
return;
this.show();
this.title.opacity = 0;
this._parentActor.raise_top();
Tweener.addTween(this.title,
{ opacity: 255,
time: CLOSE_BUTTON_FADE_TIME,
transition: 'easeOutQuad' });
},
chromeHeights: function () { chromeHeights: function () {
return [Math.max(this.borderSize, this.closeButton.height - this.closeButton._overlap), return [Math.max(this.borderSize, this.closeButton.height - this.closeButton._overlap),
this.title.height + this.title._spacing]; this.title.height + this.title._spacing];
@ -372,7 +359,6 @@ const WindowOverlay = new Lang.Class({
let border = this.border; let border = this.border;
Tweener.removeTweens(button); Tweener.removeTweens(button);
Tweener.removeTweens(title);
Tweener.removeTweens(border); Tweener.removeTweens(border);
let [cloneX, cloneY, cloneWidth, cloneHeight] = this._windowClone.slot; let [cloneX, cloneY, cloneWidth, cloneHeight] = this._windowClone.slot;
@ -1142,7 +1128,7 @@ const Workspace = new Lang.Class({
clone.actor.set_scale(scale, scale); clone.actor.set_scale(scale, scale);
clone.actor.set_opacity(255); clone.actor.set_opacity(255);
clone.overlay.relayout(false); clone.overlay.relayout(false);
this._showWindowOverlay(clone, overlay, isOnCurrentWorkspace); this._showWindowOverlay(clone, overlay);
} }
} }
}, },
@ -1172,23 +1158,19 @@ const Workspace = new Lang.Class({
time: Overview.ANIMATION_TIME, time: Overview.ANIMATION_TIME,
transition: 'easeOutQuad', transition: 'easeOutQuad',
onComplete: Lang.bind(this, function() { onComplete: Lang.bind(this, function() {
this._showWindowOverlay(clone, overlay, true); this._showWindowOverlay(clone, overlay);
}) })
}); });
clone.overlay.relayout(true); clone.overlay.relayout(true);
}, },
_showWindowOverlay: function(clone, overlay, fade) { _showWindowOverlay: function(clone, overlay) {
if (clone.inDrag) if (clone.inDrag)
return; return;
if (overlay) { if (overlay && overlay._hidden)
if (fade)
overlay.fadeIn();
else
overlay.show(); overlay.show();
}
}, },
_delayedWindowRepositioning: function() { _delayedWindowRepositioning: function() {