From 20b7d3457746633cfff36535c046763b1001d5ea Mon Sep 17 00:00:00 2001 From: Marina Zhurakhinskaya Date: Sun, 30 Jan 2011 18:08:20 -0500 Subject: [PATCH] Avoid passing 'source' as an argument to Notification::destroy() Notification::destroy() now takes 'reason' as an optional argument. Calling Notification::destroy() directly when connecting to 'destroy' on Source, as we did before, was inadvertently passing 'source' as an argument to the function. https://bugzilla.gnome.org/show_bug.cgi?id=640976 --- js/ui/messageTray.js | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/js/ui/messageTray.js b/js/ui/messageTray.js index c3eb706f9..81997df06 100644 --- a/js/ui/messageTray.js +++ b/js/ui/messageTray.js @@ -274,7 +274,11 @@ Notification.prototype = { this._capturedEventId = 0; this._keyPressId = 0; - source.connect('destroy', Lang.bind(this, this.destroy)); + source.connect('destroy', Lang.bind(this, + // Avoid passing 'source' as an argument to this.destroy() + function () { + this.destroy(); + })); this.actor = new St.Table({ name: 'notification', reactive: true });