isa/gnome-shell
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

network: Fix some splice mishaps

Browse Source 
Calling splice() without a second argument removes all of the elements
after the provided index, not just one.

https://bugzilla.gnome.org/show_bug.cgi?id=698918
This commit is contained in:
Jasper St. Pierre 2013-04-26 01:34:50 -04:00
parent 37dce7d4c3
commit 20619ad3c1
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
js/ui/status/network.js
View File

@ -1266,7 +1266,7 @@ const NMDeviceWireless = new Lang.Class({
for (let k = 0; k < connections.length; k++) { for (let k = 0; k < connections.length; k++) {
if (connections[k].get_uuid() == connection.get_uuid()) { if (connections[k].get_uuid() == connection.get_uuid()) {
// remove the connection from the access point group // remove the connection from the access point group
connections.splice(k); connections.splice(k, 1);
forceupdate = forceupdate || connections.length == 0; forceupdate = forceupdate || connections.length == 0;
if (forceupdate) if (forceupdate)
@ -2120,7 +2120,7 @@ const NMApplet = new Lang.Class({
_connectionRemoved: function(connection) { _connectionRemoved: function(connection) {
let pos = this._connections.indexOf(connection); let pos = this._connections.indexOf(connection);
if (pos != -1) if (pos != -1)
this._connections.splice(connection); this._connections.splice(connection, 1);
let section = connection._section; let section = connection._section;