From 1eeeead78f6523071606fdcfa7c4c1c48264381f Mon Sep 17 00:00:00 2001 From: Simon McVittie Date: Tue, 7 May 2013 19:25:06 +0100 Subject: [PATCH] Don't put non-Shell windows in Ctrl+Alt+Tab if they wouldn't be visible MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Metacity's Ctrl+Alt+Tab would include X11 windows with hints like GDK_WINDOW_TYPE_HINT_DOCK and GDK_WINDOW_TYPE_HINT_DESKTOP (there are more conditions, but that's a good start). If we're in normal mode, those are visible and it's OK to display those in the Ctrl+Alt+Tab order, but if we're in the lock screen or the unlock dialog, they're not visible and it doesn't make sense to focus them. Bug: https://bugzilla.gnome.org/show_bug.cgi?id=699862 Signed-off-by: Simon McVittie Reviewed-by: Florian Müllner --- js/ui/ctrlAltTab.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/js/ui/ctrlAltTab.js b/js/ui/ctrlAltTab.js index 6fbd24ebd..dbb1fe038 100644 --- a/js/ui/ctrlAltTab.js +++ b/js/ui/ctrlAltTab.js @@ -89,7 +89,7 @@ const CtrlAltTabManager = new Lang.Class({ let items = this._items.filter(function (item) { return item.proxy.mapped; }); // And add the windows metacity would show in its Ctrl-Alt-Tab list - if (!Main.overview.visible) { + if (Main.sessionMode.hasWindows && !Main.overview.visible) { let screen = global.screen; let display = screen.get_display(); let windows = display.get_tab_list(Meta.TabList.DOCKS, screen, screen.get_active_workspace ());