isa/gnome-shell
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

keyboard: Fix setting height in portrait orientation

Browse Source 
get_preferred_height() returns both the minimum and natural height,
not a single size. Math.min() doesn't handle that and returns NaN,
whoops.

https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/2349
This commit is contained in:
Florian Müllner 2020-07-04 02:22:10 +02:00 committed by Florian Müllner
parent f29dbd1f18
commit 1e72874192
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
js/ui/keyboard.js
View File

@ -1608,7 +1608,8 @@ class Keyboard extends St.BoxLayout {
* we allow the OSK being smaller than 1/3rd of the monitor height * we allow the OSK being smaller than 1/3rd of the monitor height
* there. * there.
*/ */
this.height = Math.min(maxHeight, this.get_preferred_height(monitor.width)); const [, natHeight] = this.get_preferred_height(monitor.width);
this.height = Math.min(maxHeight, natHeight);
} }
} }