isa/gnome-shell
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

status/network: Limit the number of items that are shown per section

Browse Source 
Space will be less of a concern when each sections becomes its own
menu, but it's still not infinite. To address this, enable MRU
tracking and limit the list to the eight most recently used items.

Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/2407>
This commit is contained in:
Florian Müllner 2022-08-03 18:28:46 +02:00 committed by Marge Bot
parent cb4d96072e
commit 1a0dbd00e4
1 changed files with 7 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
js/ui/status/network.js
View File

@ -1280,7 +1280,7 @@ class NMSection extends PopupMenu.PopupMenuSection {
super(); super();
this._items = new Map(); this._items = new Map();
this._itemSorter = new ItemSorter(); this._itemSorter = new ItemSorter({trackMru: true});
this._itemsSection = new PopupMenu.PopupMenuSection(); this._itemsSection = new PopupMenu.PopupMenuSection();
this.addMenuItem(this._itemsSection); this.addMenuItem(this._itemsSection);
@ -1311,6 +1311,11 @@ class NMSection extends PopupMenu.PopupMenuSection {
throw new GObject.NotImplementedError(); throw new GObject.NotImplementedError();
} }
_updateItemsVisibility() {
[...this._itemSorter.itemsByMru()].forEach(
(item, i) => (item.visible = i < MAX_VISIBLE_NETWORKS));
}
_resortItem(item) { _resortItem(item) {
const pos = this._itemSorter.upsert(item); const pos = this._itemSorter.upsert(item);
this._itemsSection.moveMenuItem(item, pos); this._itemsSection.moveMenuItem(item, pos);
@ -1345,6 +1350,7 @@ class NMSection extends PopupMenu.PopupMenuSection {
_sync() { _sync() {
this.visible = this._items.size > 0; this.visible = this._items.size > 0;
this._updateItemsVisibility();
} }
} }